Added a start for the connection abstract class#100
Closed
VladIftime wants to merge 1 commit intopairing&authfrom
Closed
Added a start for the connection abstract class#100VladIftime wants to merge 1 commit intopairing&authfrom
VladIftime wants to merge 1 commit intopairing&authfrom
Conversation
Signed-off-by: Vlad Iftime <vladiftime60@gmail.com>
Flix6x
reviewed
Apr 11, 2025
| pass | ||
|
|
||
| @abstractmethod | ||
| def handle_connection_response(self, response_data: Dict) -> Any: |
Collaborator
There was a problem hiding this comment.
What is the rationale behind using Dict over a custom type like ConnectionResponse?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.